[llvm-commits] [Patch] Add dotty dominance printer

Tobias Grosser grosser at fim.uni-passau.de
Sun Sep 27 16:36:53 PDT 2009


On Sun, 2009-09-27 at 14:55 -0700, Chris Lattner wrote:
> On Sep 20, 2009, at 6:42 AM, Tobias Grosser wrote:
> >> Patch: llvm-DominancePrinter.patch
> >> -------------------------------------------------------------------------
> >>
> >
> > This patch contained a small bug, so that the pass descriptions where
> > incomplete.
> 
> hi Tobias,
> 
> This patch doesn't build for me:
> 
> DomPrinter.cpp:33: error: ‘DOTGraphTraits’ is not a template
> DomPrinter.cpp:33: error: expected class-name before ‘{’ token
> DomPrinter.cpp:33: error: explicit specialization of non-template  
> ‘llvm::DOTGraphTraits’
> DomPrinter.cpp: In static member function ‘static std::string  
> llvm::DOTGraphTraits::getNodeLabel(llvm::DomTreeNode*,  
> llvm::DomTreeNode*, bool)’:
> DomPrinter.cpp:42: error: ‘llvm::DOTGraphTraits’ is
> ...
> 
> -Chris

Hi Chris,

sorry that I made this not clear enough. This was a patchset consisting
of three patches all contained in the first mail. The second mail just
contained an updated version for the third patch. So you still need to
apply the patch one and two from the first mail.

To make it easier I retested and rebased the patchset to current head
and attached all three patches again.

llvm-patch1-GraphTraitsforDominators.patch
llvm-patch2-Move_DOTGraphTraits.patch
llvm-patch3-DominancePrinter.patch

Tobi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-patch1-GraphTraitsforDominators.patch
Type: text/x-patch
Size: 2705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090928/76722f4b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-patch2-Move_DOTGraphTraits.patch
Type: text/x-patch
Size: 4830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090928/76722f4b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-patch3-DominancePrinter.patch
Type: text/x-patch
Size: 11083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090928/76722f4b/attachment-0002.bin>


More information about the llvm-commits mailing list