[llvm-commits] [llvm] r81719 - in /llvm/trunk: unittests/Makefile unittests/TestMain.cpp utils/unittest/Makefile utils/unittest/UnitTestMain/ utils/unittest/UnitTestMain/Makefile utils/unittest/UnitTestMain/TestMain.cpp

[Chris Lattner]

On Sep 18, 2009, at 9:11 AM, Julien Lerouge wrote:
>> +++ llvm/trunk/utils/unittest/UnitTestMain/Makefile Sun Sep 13  
>> 16:31:21 2009
>> @@ -16,9 +16,4 @@
>> CPP.Flags += -I$(LLVM_SRC_ROOT)/utils/unittest/googletest/include
>> CPP.Flags += -Wno-variadic-macros
>>
>
> -Wno-variadic-macros is not supported with older GCC, can we re-use  
> the
> logic in googletest/Makefile ? patch attached.

This patch seems reasonable to me, though an autoconf check for those  
flags would be even better (make builds go faster).

-Chris