[llvm-commits] [PATCH] Provide debug syms in release builds

[Jeffrey Yasskin]

On Fri, Sep 25, 2009 at 11:15 PM, Daniel Dunbar <daniel at zuster.org> wrote:
> On Fri, Sep 25, 2009 at 1:41 PM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>> New patch. Does this look better? (I'd already submitted the first one
>> on Chris's review, so this is just relative to that.)
>
> LGTM.
>
>> Also at http://codereview.appspot.com/124047
>>
>> On Fri, Sep 25, 2009 at 11:48 AM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>>> It looked like DEBUG_RUNTIME only affected .bc files, which can only
>>> be used if the compiler is part of the runtime.
>
> I'm not sure what "if the compiler is part of the runtime" means. The
> distinction I was making was that runtime files are built for use on
> the target, whereas the conceptual option you want (to having debug
> info in the compiler) applies to the host. To give an example of why
> this matters to me, klee use the LLVM makefile infrastructure to build
> various runtime libraries of .bc files -- I almost always want those
> to be built with DEBUG_RUNTIME, so klee can show source level debug
> information about them when linked in. On the other hand, whether or
> not I want DEBUG_SYMBOLS depends on how much disk space I feel like
> wasting. :)

Thanks, yeah, now I see the difference.

> Thanks for the patch!
>
>  - Daniel
>
>>> But I can change it.
>>> Do DEBUG_SYMBOLS and --enable-debug-symbols work for you?
>>>
>>> On Fri, Sep 25, 2009 at 11:43 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>>>> DEBUG_RUNTIME is something else entirely, and should not be conflated
>>>> with the behavior you want (it is about RUNTIME pieces, which are
>>>> conceptually part of the target, whereas you are wanting something for
>>>> the host).
>>>>
>>>> I think this should come in under a different Makefile variable and
>>>> configure option.
>>>>
>>>>  - Daniel
>>>>
>>>> On Fri, Sep 25, 2009 at 12:27 AM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>>>>> This patch causes the --enable-debug-runtime configure flag and the
>>>>> DEBUG_RUNTIME Makefile variable to pass -g to gcc when building LLVM's
>>>>> objects. Without this, it's very hard to debug crashes that happen in
>>>>> Release-Asserts mode but not Debug mode.
>>>>>
>>>>> Jeffrey
>>>>>
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>
>>>>>
>>>>
>>>
>>
>