[llvm-commits] [llvm] r79091 - in /llvm/trunk/lib/Target/PowerPC: AsmPrinter/PPCAsmPrinter.cpp PPCFrameInfo.h PPCISelLowering.cpp PPCISelLowering.h PPCInstr64Bit.td PPCInstrInfo.td PPCRegisterInfo.cpp PPCRegisterInfo.td PPCSubtarget.h

[Chris Lattner]

On Aug 22, 2009, at 12:58 PM, Chris Lattner wrote:

>
> On Aug 15, 2009, at 4:54 AM, Tilmann Scheller wrote:
>
>> Author: tilmann
>> Date: Sat Aug 15 06:54:46 2009
>> New Revision: 79091
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79091&view=rev
>> Log:
>> Add support for the PowerPC 64-bit SVR4 ABI.
>
> Thanks for doing this Tilmann, one minor comment:
>
>> +    static const std::pair<unsigned, int> Offsets64[] = {
>> +      // Floating-point register save area offsets.
>> +      std::pair<unsigned, int>(PPC::F31, -8),
>
> Please use an explicit struct for this instead of std::pair.
> std::pair is not considered a C++ "aggregate" type, so I think that
> the init of this will happen at runtime the first time the code is  
> run.

Tilmann, ping?

-Chris