[llvm-commits] [Fwd: [llvm] r82689 - in /llvm/trunk: lib/Transforms/IPO/IPConstantPropagation.cpp lib/Transforms/Scalar/SCCP.cpp test/Transforms/IPConstantProp/2009-09-24-byval-ptr.ll]

[Török Edwin]

On 2009-09-24 18:28, Chris Lattner wrote:
>
> On Sep 24, 2009, at 3:07 AM, Török Edwin wrote:
>
>> Hi Tanya,
>>
>> If there is still time, can you pull this into 2.6?
>>
>> It fixes a rather serious bug in ipsccp, see PR5038 (modifying a struct
>> passed byval changed the original struct passed, because IPSCCP constant
>> propagated the pointer).
>
> I agree that this would be nice to fix for 2.6, but it may be too
> late.  It depends on the fate of PR5004, which is still pending.  

Ok, if you do pull this patch into 2.6 please pull 82700 too (it fixes
the code pessimization I mentioned, and its just a few lines again).

> Tanya, what do you think?
>
> -Chris