[llvm-commits] [compiler-rt] r82605 - /compiler-rt/trunk/BlocksRuntime/runtime.c

[Edward O'Callaghan]

I must confess to not looking at the context and fixing this at around 5am.

2009/9/23 John McCall <rjmccall at apple.com>:
> Daniel Dunbar wrote:
>
> Hi Edward,
>
> On Tue, Sep 22, 2009 at 8:47 PM, Edward O'Callaghan
> <eocallaghan at auroraux.org> wrote:
>
>
> Author: evocallaghan
> Date: Tue Sep 22 22:47:24 2009
> New Revision: 82605
>
> URL: http://llvm.org/viewvc/llvm-project?rev=82605&view=rev
> Log:
> Fix compile time warning: format '%#lx' expects type 'long unsigned int',
> but argument 3 has type 'unsigned int'
>
>
> This isn't correct (of course, neither was the original). Argument 3
> has type uintptr_t, which is not necessarily unsigned int. To be more
> painfully portable it should probably always print as a uint64_t (I
> confess to not looking at the context).
>
> Is there a problem preventing us from using %p to display these pointer
> values instead of hacking together our own equivalent?
>
> John.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>



-- 
-- 
Edward O'Callaghan
http://www.auroraux.org/
eocallaghan at auroraux dot org