[llvm-commits] [llvm] r82503 - /llvm/trunk/lib/CodeGen/LowerSubregs.cpp

[Evan Cheng]

On Sep 21, 2009, at 9:50 PM, Jakob Stoklund Olesen wrote:

> Evan Cheng <evan.cheng at apple.com> writes:
>
>> Minor bug fix. LowerSubregs should translate
>> %S0<def> = EXTRACT_SUBREG %Q0<kill>, 1
>> to
>> %S0<def> = IMPLICIT_DEF %Q0<imp-use,kill>
>>
>> Implicit_def does not *read* any register so the operand should be
>> marked "implicit". The missing "implicit" marker on the operand is
>> wrong, but it doesn't actually break anything.
>
> Thanks.
>
> Is IMPLICIT_DEF variadic? Otherwise, the machine code verifier should
> have caught this.

It's not variadic. I am not sure why the machine verifier didn't catch  
this.

Evan

>
> /jakob
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits