[llvm-commits] [llvm] r82485 - in /llvm/trunk: lib/CodeGen/SimpleRegisterCoalescing.cpp lib/CodeGen/SimpleRegisterCoalescing.h test/CodeGen/ARM/2008-11-19-ScavengerAssert.ll test/CodeGen/ARM/remat.ll test/CodeGen/X86/2008-02-22-ReMatBug.ll test/CodeGen/X86/2008-07-11-SpillerBug.ll test/CodeGen/X86/2009-04-20-LinearScanOpt.ll test/CodeGen/X86/2009-09-21-NoSpillLoopCount.ll test/CodeGen/X86/stack-color-with-reg.ll

Evan Cheng evan.cheng at apple.com
Mon Sep 21 18:39:40 PDT 2009


On Sep 21, 2009, at 6:36 PM, Dan Gohman wrote:

>
> On Sep 21, 2009, at 2:12 PM, Evan Cheng wrote:
>
>> +        float Weight = li_->getSpillWeight(HasDef, HasUse,  
>> loopDepth+1);
>
>> -            RegInt.weight +=
>> -              li_->getSpillWeight(mop.isDef(), mop.isUse(),  
>> loopDepth);
>
> Why the change from loopDepth to loopDepth+1? This seems inconsistent
> with LiveIntervalAnalysis.cpp's call to getSpillWeight, which just
> passes in the normal spill weight.

Oops. That's a real cut and paste bug.

Evan

>
> Dan
>




More information about the llvm-commits mailing list