[llvm-commits] [llvm] r81704 - in /llvm/trunk/lib/Target/X86/AsmPrinter: X86ATTInstPrinter.cpp X86IntelAsmPrinter.cpp

[Chris Lattner]

Author: lattner
Date: Sun Sep 13 14:44:38 2009
New Revision: 81704

URL: http://llvm.org/viewvc/llvm-project?rev=81704&view=rev
Log:
make intel asmprinter use TRI::getAsmName instead of TRI::getName like
all the other targets.  Add support for weak/linkonce linkage so it doesn't
crash on basically all nontrivial testcases.

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp
    llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp?rev=81704&r1=81703&r2=81704&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp Sun Sep 13 14:44:38 2009
@@ -70,9 +70,7 @@
   
   const MCOperand &Op = MI->getOperand(OpNo);
   if (Op.isReg()) {
-    O << '%';
-    unsigned Reg = Op.getReg();
-    O << TRI->getAsmName(Reg);
+    O << '%' << TRI->getAsmName(Op.getReg());
     return;
   } else if (Op.isImm()) {
     O << '$' << Op.getImm();

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp?rev=81704&r1=81703&r2=81704&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp Sun Sep 13 14:44:38 2009
@@ -149,6 +149,11 @@
 
   switch (F->getLinkage()) {
   default: llvm_unreachable("Unsupported linkage type!");
+  case Function::LinkOnceAnyLinkage:
+  case Function::LinkOnceODRLinkage:
+  case Function::WeakAnyLinkage:
+  case Function::WeakODRLinkage:
+      
   case Function::PrivateLinkage:
   case Function::LinkerPrivateLinkage:
   case Function::InternalLinkage:
@@ -204,21 +209,24 @@
   }
 }
 
+static void PrintRegName(raw_ostream &O, StringRef RegName) {
+  for (unsigned i = 0, e = RegName.size(); i != e; ++i)
+    O << (char)toupper(RegName[i]);
+}
+
 void X86IntelAsmPrinter::printOp(const MachineOperand &MO,
                                  const char *Modifier) {
   switch (MO.getType()) {
   case MachineOperand::MO_Register: {
-    if (TargetRegisterInfo::isPhysicalRegister(MO.getReg())) {
-      unsigned Reg = MO.getReg();
-      if (Modifier && strncmp(Modifier, "subreg", strlen("subreg")) == 0) {
-        EVT VT = (strcmp(Modifier,"subreg64") == 0) ?
-          MVT::i64 : ((strcmp(Modifier, "subreg32") == 0) ? MVT::i32 :
-                      ((strcmp(Modifier,"subreg16") == 0) ? MVT::i16 :MVT::i8));
-        Reg = getX86SubSuperRegister(Reg, VT);
-      }
-      O << TRI->getName(Reg);
-    } else
-      O << "reg" << MO.getReg();
+    assert(TargetRegisterInfo::isPhysicalRegister(MO.getReg()));
+    unsigned Reg = MO.getReg();
+    if (Modifier && strncmp(Modifier, "subreg", strlen("subreg")) == 0) {
+      EVT VT = (strcmp(Modifier,"subreg64") == 0) ?
+        MVT::i64 : ((strcmp(Modifier, "subreg32") == 0) ? MVT::i32 :
+                    ((strcmp(Modifier,"subreg16") == 0) ? MVT::i16 :MVT::i8));
+      Reg = getX86SubSuperRegister(Reg, VT);
+    }
+    PrintRegName(O, TRI->getAsmName(Reg));
     return;
   }
   case MachineOperand::MO_Immediate:
@@ -391,7 +399,7 @@
     break;
   }
 
-  O << TRI->getName(Reg);
+  PrintRegName(O, TRI->getAsmName(Reg));
   return false;
 }