[llvm-commits] [llvm] r81415 - in /llvm/trunk: lib/CodeGen/SelectionDAG/FastISel.cpp test/CodeGen/X86/fast-isel-fneg.ll

Bob Wilson bob.wilson at apple.com
Wed Sep 9 17:49:22 PDT 2009


Author: bwilson
Date: Wed Sep  9 19:49:22 2009
New Revision: 81415

URL: http://llvm.org/viewvc/llvm-project?rev=81415&view=rev
Log:
Revert r81171 which was causing pr4927.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
    llvm/trunk/test/CodeGen/X86/fast-isel-fneg.ll

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=81415&r1=81414&r2=81415&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp Wed Sep  9 19:49:22 2009
@@ -615,25 +615,12 @@
   unsigned OpReg = getRegForValue(BinaryOperator::getFNegArgument(I));
   if (OpReg == 0) return false;
 
-  // Bitcast the value to integer, twiddle the sign bit with xor,
-  // and then bitcast it back to floating-point.
+  // Twiddle the sign bit with xor.
   EVT VT = TLI.getValueType(I->getType());
   if (VT.getSizeInBits() > 64) return false;
-  EVT IntVT = EVT::getIntegerVT(I->getContext(), VT.getSizeInBits());
-
-  unsigned IntReg = FastEmit_r(VT.getSimpleVT(), IntVT.getSimpleVT(),
-                               ISD::BIT_CONVERT, OpReg);
-  if (IntReg == 0)
-    return false;
-
-  unsigned IntResultReg = FastEmit_ri_(IntVT.getSimpleVT(), ISD::XOR, IntReg,
-                                       UINT64_C(1) << (VT.getSizeInBits()-1),
-                                       IntVT.getSimpleVT());
-  if (IntResultReg == 0)
-    return false;
-
-  unsigned ResultReg = FastEmit_r(IntVT.getSimpleVT(), VT.getSimpleVT(),
-                                  ISD::BIT_CONVERT, IntResultReg);
+  unsigned ResultReg = FastEmit_ri_(VT.getSimpleVT(), ISD::XOR, OpReg,
+                                    UINT64_C(1) << (VT.getSizeInBits()-1),
+                                    VT.getSimpleVT());
   if (ResultReg == 0)
     return false;
 

Modified: llvm/trunk/test/CodeGen/X86/fast-isel-fneg.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fast-isel-fneg.ll?rev=81415&r1=81414&r2=81415&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/X86/fast-isel-fneg.ll (original)
+++ llvm/trunk/test/CodeGen/X86/fast-isel-fneg.ll Wed Sep  9 19:49:22 2009
@@ -1,14 +1,14 @@
-; RUN: llc < %s -fast-isel -fast-isel-abort -march=x86-64 | FileCheck %s
+; RUN: llc < %s -fast-isel -march=x86-64 | FileCheck %s
 
 ; CHECK: doo:
-; CHECK: xor
+; CHECK: xorpd
 define double @doo(double %x) nounwind {
   %y = fsub double -0.0, %x
   ret double %y
 }
 
 ; CHECK: foo:
-; CHECK: xor
+; CHECK: xorps
 define float @foo(float %x) nounwind {
   %y = fsub float -0.0, %x
   ret float %y





More information about the llvm-commits mailing list