[llvm-commits] [llvm] r81246 - in /llvm/trunk: include/llvm/System/Program.h lib/System/Unix/Program.inc lib/System/Win32/Program.inc

[Duncan Sands]

Hi Mikhail,

> +    bool Kill
> +    ( std::string* ErrMsg = 0 ///< If non-zero, provides a pointer to a string
> +      ///< instance in which error messages will be returned. If the string
> +      ///< is non-empty upon return an error occurred while invoking the
> +      ///< program.

while invoking the program -> while killing the program

> +  return (kill(Pid_, SIGKILL) == 0);

Here you don't set the error string if there was an error.  The
description of the function suggests that the error string should
be non-empty if there is an error - not the case here.

Likewise for the other implementation.

Ciao,

Duncan.