[llvm-commits] [llvm] r81304 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp

[Chris Lattner]

Author: lattner
Date: Tue Sep  8 19:40:31 2009
New Revision: 81304

URL: http://llvm.org/viewvc/llvm-project?rev=81304&view=rev
Log:
tidy up

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp?rev=81304&r1=81303&r2=81304&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp Tue Sep  8 19:40:31 2009
@@ -76,20 +76,10 @@
   if (Op.isReg()) {
     O << '%';
     unsigned Reg = Op.getReg();
-#if 0
-    if (Modifier && strncmp(Modifier, "subreg", strlen("subreg")) == 0) {
-      EVT VT = (strcmp(Modifier+6,"64") == 0) ?
-      EVT::i64 : ((strcmp(Modifier+6, "32") == 0) ? EVT::i32 :
-                  ((strcmp(Modifier+6,"16") == 0) ? EVT::i16 : EVT::i8));
-      Reg = getX86SubSuperRegister(Reg, VT);
-    }
-#endif
     O << TRI->getAsmName(Reg);
     return;
   } else if (Op.isImm()) {
-    //if (!Modifier || (strcmp(Modifier, "debug") && strcmp(Modifier, "mem")))
-    O << '$';
-    O << Op.getImm();
+    O << '$' << Op.getImm();
     return;
   } else if (Op.isExpr()) {
     O << '$';
@@ -101,7 +91,6 @@
 }
 
 void X86ATTAsmPrinter::printLeaMemReference(const MCInst *MI, unsigned Op) {
-
   const MCOperand &BaseReg  = MI->getOperand(Op);
   const MCOperand &IndexReg = MI->getOperand(Op+2);
   const MCOperand &DispSpec = MI->getOperand(Op+3);
@@ -110,20 +99,12 @@
     int64_t DispVal = DispSpec.getImm();
     if (DispVal || (!IndexReg.getReg() && !BaseReg.getReg()))
       O << DispVal;
-  } else if (DispSpec.isExpr()) {
-    DispSpec.getExpr()->print(O, MAI);
   } else {
-    llvm_unreachable("non-immediate displacement for LEA?");
-    //assert(DispSpec.isGlobal() || DispSpec.isCPI() ||
-    //       DispSpec.isJTI() || DispSpec.isSymbol());
-    //printOperand(MI, Op+3, "mem");
+    assert(DispSpec.isExpr() && "non-immediate displacement for LEA?");
+    DispSpec.getExpr()->print(O, MAI);
   }
   
   if (IndexReg.getReg() || BaseReg.getReg()) {
-    // There are cases where we can end up with ESP/RSP in the indexreg slot.
-    // If this happens, swap the base/index register to support assemblers that
-    // don't work when the index is *SP.
-    // FIXME: REMOVE THIS.
     assert(IndexReg.getReg() != X86::ESP && IndexReg.getReg() != X86::RSP);
     
     O << '(';