[llvm-commits] [llvm] r81193 - /llvm/trunk/lib/VMCore/Verifier.cpp
Nick Lewycky
nicholas at mxc.ca
Mon Sep 7 22:46:15 PDT 2009
Author: nicholas
Date: Tue Sep 8 00:46:15 2009
New Revision: 81193
URL: http://llvm.org/viewvc/llvm-project?rev=81193&view=rev
Log:
Hoist out the test+insert to CheckedTypes. This doesn't seem to affect
performance.
Modified:
llvm/trunk/lib/VMCore/Verifier.cpp
Modified: llvm/trunk/lib/VMCore/Verifier.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Verifier.cpp?rev=81193&r1=81192&r2=81193&view=diff
==============================================================================
--- llvm/trunk/lib/VMCore/Verifier.cpp (original)
+++ llvm/trunk/lib/VMCore/Verifier.cpp Tue Sep 8 00:46:15 2009
@@ -1447,12 +1447,10 @@
/// VerifyType - Verify that a type is well formed.
///
void Verifier::VerifyType(const Type *Ty) {
- // We insert complex types into CheckedTypes even if they failed verification
- // to prevent emitting messages about them multiple times if
+ if (!CheckedTypes.insert(Ty)) return;
switch (Ty->getTypeID()) {
case Type::FunctionTyID: {
- if (!CheckedTypes.insert(Ty)) return;
const FunctionType *FTy = cast<FunctionType>(Ty);
const Type *RetTy = FTy->getReturnType();
@@ -1468,7 +1466,6 @@
}
} break;
case Type::StructTyID: {
- if (!CheckedTypes.insert(Ty)) return;
const StructType *STy = cast<StructType>(Ty);
for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {
const Type *ElTy = STy->getElementType(i);
@@ -1478,28 +1475,25 @@
}
} break;
case Type::ArrayTyID: {
- if (!CheckedTypes.insert(Ty)) return;
const ArrayType *ATy = cast<ArrayType>(Ty);
Assert1(ArrayType::isValidElementType(ATy->getElementType()),
"Array type with invalid element type", ATy);
VerifyType(ATy->getElementType());
} break;
case Type::PointerTyID: {
- if (!CheckedTypes.insert(Ty)) return;
const PointerType *PTy = cast<PointerType>(Ty);
Assert1(PointerType::isValidElementType(PTy->getElementType()),
"Pointer type with invalid element type", PTy);
VerifyType(PTy->getElementType());
- }
+ } break;
case Type::VectorTyID: {
- if (!CheckedTypes.insert(Ty)) return;
const VectorType *VTy = cast<VectorType>(Ty);
Assert1(VectorType::isValidElementType(VTy->getElementType()),
"Vector type with invalid element type", VTy);
VerifyType(VTy->getElementType());
- }
+ } break;
default:
- return;
+ break;
}
}
More information about the llvm-commits
mailing list