[llvm-commits] [llvm] r81126 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

[Evan Cheng]

This seems wrong. Perhaps the switch statement should be something  
like this?

   case X86II::MO_NO_FLAG:    // No flag.
     break;
   case X86II::MO_PIC_BASE_OFFSET:
   case X86II::MO_DARWIN_NONLAZY_PIC_BASE:
   case X86II::MO_DARWIN_HIDDEN_NONLAZY_PIC_BASE:
     // Subtract the pic base.
     NegatedSymbol = GetPICBaseSymbol();
     break;

Evan

On Sep 6, 2009, at 12:27 PM, Duncan Sands wrote:

> Author: baldrick
> Date: Sun Sep  6 14:27:53 2009
> New Revision: 81126
>
> URL: http://llvm.org/viewvc/llvm-project?rev=81126&view=rev
> Log:
> Remove unreachable code.
>
> Modified:
>    llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
>
> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp?rev=81126&r1=81125&r2=81126&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp (original)
> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp Sun Sep   
> 6 14:27:53 2009
> @@ -127,9 +127,6 @@
>   case X86II::MO_DARWIN_NONLAZY_PIC_BASE:
>   case X86II::MO_DARWIN_HIDDEN_NONLAZY_PIC_BASE:
>     break;
> -    // Subtract the pic base.
> -    GetPICBaseSymbol();
> -    break;
>   }
>
>   // Create a symbol for the name.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits