[llvm-commits] [llvm] r81114 - in /llvm/trunk/lib/Support: regcomp.c regerror.c regutils.h

Török Edwin edwintorok at gmail.com
Sun Sep 6 05:40:07 PDT 2009


On 2009-09-06 15:26, Benjamin Kramer wrote:
> Author: d0k
> Date: Sun Sep  6 07:26:28 2009
> New Revision: 81114
>
> URL: http://llvm.org/viewvc/llvm-project?rev=81114&view=rev
> Log:
> More MSVC warning fixes:
> 1. DUPMAX is defined in regcomp.c, no need to redefine it in regutils.
> 2. MSVC doesn't like snprintf, use _snprintf instead.
>   

MSVC's _snprintf isn't the same as POSIX snprintf, or has that changed
lately?
http://www.winehq.org/pipermail/wine-devel/2006-September/050751.html

Anyway for reg* stuff I think its ok, they never use the return value of
snprintf,
and the buffers are large enough.


Best regards,
--Edwin




More information about the llvm-commits mailing list