[llvm-commits] [llvm-gcc-4.2] r81054 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

Duncan Sands baldrick at free.fr
Sat Sep 5 01:35:02 PDT 2009


Hi Bob,

> Preserve alignment settings for string constants. 

CONSTANT_ALIGNMENT is for all constants, not just strings.
Can you please make the corresponding change for other
constants.

> +  unsigned align = TYPE_ALIGN(TREE_TYPE(exp));
> +#ifdef CONSTANT_ALIGNMENT
> +  align = CONSTANT_ALIGNMENT (exp, align);
> +#endif

This logic could be factored into a get_constant_alignment
method, like that (static) one in varasm.c.

Ciao,

Duncan.



More information about the llvm-commits mailing list