[llvm-commits] [llvm-gcc-4.2] r81037 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Dale Johannesen]

Author: johannes
Date: Fri Sep  4 15:16:58 2009
New Revision: 81037

URL: http://llvm.org/viewvc/llvm-project?rev=81037&view=rev
Log:
Adjust check added in 71555; that's checking for an
invariant that doesn't hold for the code generated
for MODIFY_EXPR.


Modified:
    llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=81037&r1=81036&r2=81037&view=diff

==============================================================================
--- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
+++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Fri Sep  4 15:16:58 2009
@@ -975,6 +975,11 @@
           // pass it back as a scalar value. Disable checking if it's a
           // vector. This should be made better, though.
           isa<VectorType>(ConvertType(TREE_TYPE(exp))) ||
+          // FIXME: The handling of MODIFY_EXPR doesn't always produce results
+          // that pass this check; the return type might be the LHS type or
+          // the RHS type, neither of which is guaranteed to be the
+          // same as the expression type.
+          TREE_CODE(exp) == MODIFY_EXPR ||
           Result->getType() == ConvertType(TREE_TYPE(exp))) &&
           "Value has wrong type!");
   return Result;