[llvm-commits] [llvm] r80715 - in /llvm/trunk: include/llvm/Analysis/ProfileInfoLoader.h lib/Analysis/ProfileInfoLoader.cpp lib/Analysis/ProfileInfoLoaderPass.cpp

[Daniel Dunbar]

On Wed, Sep 2, 2009 at 3:49 AM, Andreas Neustifter<astifter-llvm at gmx.at> wrote:
> Daniel Dunbar wrote:
>
> I found this code _very_ ugly myself, is was planing on cleaning it up
> today, thanks for the hints!

Cool.

>> Do these values need to become uint64_t at some point?
>
> Was thinking about that because there is no gurantee that the counters do
> not overflow. But this would be a major change, in the complete tool chain,
> but I will look into this.

Yeah, no rush. The code could always just assert that the overflow
doesn't happen, and we can fix it when it becomes a problem. For now I
think you are right there is more important stuff to work on. :)

 - Daniel