[llvm-commits] [llvm] r80589 - /llvm/trunk/lib/System/DynamicLibrary.cpp

[Török Edwin]

On 2009-08-31 20:06, Chris Lattner wrote:
>
> On Aug 31, 2009, at 9:12 AM, Torok Edwin wrote:
>
>> Author: edwin
>> Date: Mon Aug 31 11:12:29 2009
>> New Revision: 80589
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=80589&view=rev
>> Log:
>> Fix ExplicitSymbols leak.
>
> Edwin, can this be a ManagedStatic, or something else that doesn't
> have a static ctor/dtor?

Thought about it, but there are 2 issues:
- AddSymbol is called from a static constructor in another file:
ExecutionEngine/JIT/Intercept.cpp (the fstat workaround for Linux).
- using ManagedStatic in System would create a circular dep between
Support and System, llvm-config doesn't like that

I only added a static destructor, ExplicitSymbols is still created on
first use, when needed, so there is no static constructor currently :)

Best regards,
--Edwin