[llvm-commits] [llvm] r80428 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/AsmPrinter/DwarfException.cpp lib/Target/PowerPC/PPCISelLowering.cpp lib/Target/PowerPC/PPCISelLowering.h lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h

[Duncan Sands]

Hi Bill,

> -    Asm->EmitInt8(dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4);
> -    Asm->EOL("FDE Encoding (pcrel sdata4)");
> +    Encoding = Asm->TM.getTargetLowering()->getPreferredLSDADataFormat();
> +    Asm->EmitInt8(Encoding);
> +    Asm->EOL("LSDA Encoding", Encoding);

here you state how you will output the data.  But I don't see the
corresponding changes to the places where the data is actually output.

> +  bool is4Byte = TD->getPointerSize() == sizeof(int32_t);

Since sizeof(int32_t) is equal to 4 and always will be, why not just use
4 here?

> +  MF = 0;

Not sure what this is about?

Ciao,

Duncan.