[llvm-commits] [llvm] r80265 - /llvm/trunk/lib/VMCore/Value.cpp

[Chris Lattner]

On Aug 27, 2009, at 11:46 PM, Eli Friedman wrote:

> On Thu, Aug 27, 2009 at 10:01 PM, Chris Lattner<clattner at apple.com>  
> wrote:
>>
>> On Aug 27, 2009, at 3:40 PM, Dan Gohman wrote:
>>
>>>>
>>>> Shouldn't a alias constant-fold to the pointed-to global if it  
>>>> can't
>>>> be overridden?
>>>
>>> Right now only GlobalOpt does this, and not everyone uses
>>> GlobalOpt. I could be convinced that Instcombine should
>>> do this though. Does anyone have a strong opinion?
>>
>> Instcombine a functionpass, which shouldn't hack on globals.
>
> The proposed transformation is not hacking *on* the alias, it's
> transforming a use.  Sort of like transforming a constant icmp of two
> globals.

Ah sure, instcombine could do that.  One issue is that inscombine  
doesn't do a lot of things with operands, but I'm not opposed to that  
in principle.

-Chris