[llvm-commits] [llvm] r79898 - /llvm/trunk/lib/MC/MCAssembler.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Mon Aug 24 03:39:57 2009
New Revision: 79898

URL: http://llvm.org/viewvc/llvm-project?rev=79898&view=rev
Log:
llvm-mc: Tweak undefined symbol handling.

Modified:
    llvm/trunk/lib/MC/MCAssembler.cpp

Modified: llvm/trunk/lib/MC/MCAssembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=79898&r1=79897&r2=79898&view=diff

==============================================================================
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)
+++ llvm/trunk/lib/MC/MCAssembler.cpp Mon Aug 24 03:39:57 2009
@@ -294,7 +294,7 @@
     // FIXME: Set private external bit.
 
     // Set external bit.
-    if (MSD.SymbolData->isExternal())
+    if (MSD.SymbolData->isExternal() || Symbol.isUndefined())
       Type |= STF_External;
 
     // struct nlist (12 bytes)
@@ -339,7 +339,7 @@
            ie = Asm.symbol_end(); it != ie; ++it) {
       MCSymbol &Symbol = it->getSymbol();
 
-      if (!it->isExternal())
+      if (!it->isExternal() && !Symbol.isUndefined())
         continue;
 
       uint64_t &Entry = StringIndexMap[Symbol.getName()];
@@ -371,7 +371,7 @@
            ie = Asm.symbol_end(); it != ie; ++it) {
       MCSymbol &Symbol = it->getSymbol();
 
-      if (it->isExternal())
+      if (it->isExternal() || Symbol.isUndefined())
         continue;
 
       uint64_t &Entry = StringIndexMap[Symbol.getName()];
@@ -385,7 +385,6 @@
       MSD.SymbolData = it;
       MSD.StringIndex = Entry;
 
-      assert(!Symbol.isUndefined() && "Local symbol can not be undefined!");
       if (Symbol.isAbsolute()) {
         MSD.SectionIndex = 0;
         LocalSymbolData.push_back(MSD);