[llvm-commits] [llvm] r78872 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp

[Chris Lattner]

On Aug 23, 2009, at 12:01 PM, Nick Kledzik wrote:

>>>
>>> I suppose.  There are some in the gcc testsuite.  I was asked not  
>>> to run it anymore but somebody should be; it's the best tests we  
>>> have for ObjC metadata.
>>>
>>>> Do ppc/arm need a similar fix?
>>>
>>> Probably, good catch, I'll look at it.
>>>
>>
>> I still don't understand what this is doing.  "l" labels are not  
>> visible outside of their translation unit. Why could they possibly  
>> need to be marked as weak definitions?  They can't be overridden by  
>> other translation units, so it doesn't make sense (to me) for them  
>> to have to be weak.
>
> Chris, it is 'L' labels that are visible on in their translation  
> unit.  'l' labels are visible throughout the linkage unit.   Making  
> these weak-hidden enables the linker to coalesce duplicates.

Aha, that makes perfect sense.  I'll update the documentation.  Thanks  
Nick.

Also, thank you for tracking this down and fixing it Dale!!

-Chris