[llvm-commits] [llvm] r79711 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Eric Christopher]

Will do.

Sent from my iPhone

On Aug 21, 2009, at 6:56 PM, Owen Anderson <resistor at mac.com> wrote:

> Ack!  This isn't correct!
>
> I'm not at a machine where I can commit, so can someone either  
> revert this patch and my preceding one (r79708), or apply the  
> obvious fix by restoring the static and placing the lock acquire in  
> the true branch of the if statement in getValueTypeList().  Since  
> this is just a performance optimization, I'd rather have this  
> reverted than have buggy stuff in 2.6.
>
> Thanks,
>
> --Owen
>
>
> On Friday, August 21, 2009, at 07:41PM, "Eric Christopher" <echristo at apple.com 
> > wrote:
>> Author: echristo
>> Date: Fri Aug 21 19:41:47 2009
>> New Revision: 79711
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79711&view=rev
>> Log:
>> Actually remove unused static. Previous commit removed trailing
>> whitespace.
>>
>> Modified:
>>   llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
>>
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=79711&r1=79710&r2=79711&view=diff
>>
>> === 
>> === 
>> === 
>> =====================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Fri Aug 21  
>> 19:41:47 2009
>> @@ -5017,7 +5017,6 @@
>>
>> static ManagedStatic<std::set<EVT, EVT::compareRawBits> > EVTs;
>> static EVT VTs[MVT::LAST_VALUETYPE];
>> -static ManagedStatic<sys::SmartMutex<true> > VTMutex;
>>
>> /// getValueTypeList - Return a pointer to the specified value type.
>> ///
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>