[llvm-commits] [llvm] r79631 - in /llvm/trunk/lib/Target/PIC16: AsmPrinter/PIC16AsmPrinter.cpp AsmPrinter/PIC16AsmPrinter.h MCSectionPIC16.h PIC16.h PIC16PAN.h PIC16Passes/Makefile PIC16Passes/PIC16FrameOverlay.cpp PIC16Passes/PIC16FrameOverlay.h PIC16TargetObjectFile.cpp PIC16TargetObjectFile.h

[Sanjiv Gupta]

Chris Lattner wrote:
>
> On Aug 21, 2009, at 8:22 AM, Sanjiv Gupta wrote:
>
>> Author: sgupta
>> Date: Fri Aug 21 10:22:33 2009
>> New Revision: 79631
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79631&view=rev
>> Log:
>> Add a pass to do call graph analyis to overlay the autos and frame 
>> sections of
>> leaf functions. This pass will be extended to color other nodes of 
>> the call tree
>> as well in future.
>
> Sanjiv, this commit, r79562 and r79563 are not the right way to tackle 
> this problem, and are coming in the day of the release branch.  Please 
> revert them and propose patches for these on llvmdev.
>
> -Chris
>
Chris,
Both these passes are currently optional (loadable modules) and are 
entirely pic16 specific. They are just the framework on which we intend 
to build upon and currently do not run by default. Do you still feel 
that these need to reverted back.

- Sanjiv