[llvm-commits] [llvm] r79562 - in /llvm/trunk/lib/Target/PIC16: AsmPrinter/PIC16AsmPrinter.cpp AsmPrinter/PIC16AsmPrinter.h Makefile PIC16.h PIC16ISelLowering.cpp PIC16ISelLowering.h PIC16InstrInfo.td PIC16PAN.h PIC16TargetObjectFile.cpp PIC16TargetObjectFile.h

[Chris Lattner]

On Aug 20, 2009, at 12:28 PM, Sanjiv Gupta wrote:

> Author: sgupta
> Date: Thu Aug 20 14:28:24 2009
> New Revision: 79562
>
> URL: http://llvm.org/viewvc/llvm-project?rev=79562&view=rev
> Log:
> Implement support for ISRs.
> Clone functions that are shared between the Main thread and  
> Interrupt thread.
> CallSites are changed in AsmPrinter currently. A better solution  
> would have been to modify the legalizer (SoftenFloat) to allow  
> targets to change the name of libcalls for float operations. But  
> that currently breaks other targets.
> Also, cloing of automatic variables is done AsmPrinter, a better  
> approach would
> be to use the ValueMap in CloneFunction itself.

Sanjiv,

Why are you doing this in the code generator instead of in the  
frontend as discussed on llvmdev?

-Chris