[llvm-commits] [gcc-plugin] r79528 - /gcc-plugin/trunk/llvm-convert.cpp

[Duncan Sands]

Author: baldrick
Date: Thu Aug 20 07:50:45 2009
New Revision: 79528

URL: http://llvm.org/viewvc/llvm-project?rev=79528&view=rev
Log:
Erasure of local values isn't implemented yet - just
turn it off.  Now that we don't cache inside trees,
this could be done differently - add a note about this.

Modified:
    gcc-plugin/trunk/llvm-convert.cpp

Modified: gcc-plugin/trunk/llvm-convert.cpp
URL: http://llvm.org/viewvc/llvm-project/gcc-plugin/trunk/llvm-convert.cpp?rev=79528&r1=79527&r2=79528&view=diff

==============================================================================
--- gcc-plugin/trunk/llvm-convert.cpp (original)
+++ gcc-plugin/trunk/llvm-convert.cpp Thu Aug 20 07:50:45 2009
@@ -729,9 +729,11 @@
       SI->setSuccessor(0, SI->getSuccessor(1));
   }
 
-  // Remove any cached LLVM values that are local to this function.  Such values
-  // may be deleted when the optimizers run, so would be dangerous to keep.
-  eraseLocalLLVMValues();
+// Local llvm values should probably just be cached in a local map, making this
+// routine unnecessary.
+//TODO  // Remove any cached LLVM values that are local to this function.  Such values
+//TODO  // may be deleted when the optimizers run, so would be dangerous to keep.
+//TODO  eraseLocalLLVMValues();
 
   // Simplify any values that were uniqued using a no-op bitcast.
   for (std::vector<BitCastInst *>::iterator I = UniquedValues.begin(),