[llvm-commits] [llvm] r79401 - /llvm/trunk/include/llvm/CodeGen/ValueTypes.h

Erick Tryzelaar idadesub at users.sourceforge.net
Wed Aug 19 16:24:51 PDT 2009


On Wed, Aug 19, 2009 at 11:44 AM, Bill Wendling<wendling at apple.com> wrote:
> On Aug 18, 2009, at 7:53 PM, Erick Tryzelaar wrote:
>
> Hi Erick,
>
> Why did you choose the name "FirstExtendedValueType"? If it's a sentinel,
> maybe just name it so...

I named it that since it appears that extended value types start at
256. But you're right, I probably should have named it something else.
Following the other variants, does "INVALID_SIMPLE_VALUE_TYPE" sound
reasonable? I can also rename all of the LastSimpleValueType+1
expressions with it.



More information about the llvm-commits mailing list