[llvm-commits] [llvm] r79308 - /llvm/trunk/Makefile.rules

[Eric Christopher]

On Aug 18, 2009, at 10:48 AM, Rafael Espindola wrote:

> 2009/8/18 Eric Christopher <echristo at apple.com>:
>> Author: echristo
>> Date: Mon Aug 17 22:23:40 2009
>> New Revision: 79308
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79308&view=rev
>> Log:
>> Separate out Makefile defines so that we can keep the llvm
>> defined ones from the user defined ones. Propagate accordingly.
>
> Looks like this broke libLLVMgold.so  build. Before your patch I  
> would get
>
> ldd  Debug/lib/libLLVMgold.so  | grep LTO
>        libLTO.so => ......./llvm-build/Debug/lib/libLTO.so  
> (0x00007fd64f3d0000)
>
> now I get
>
> ldd  Debug/lib/libLLVMgold.so  | grep LTO
> <nothing>

This is because I didn't put CXXFLAGS on the Link line and I'm  
guessing due to the case sensitivity of LIBS/CXXFLAGS that it didn't  
link in libLTO and tried for liblto.

At any rate $(CXX.Flags) is on the LINK line so I'll add CXXFLAGS as  
well.

-eric