[llvm-commits] [llvm] r78295 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/wide-integer-fold.ll

[Duncan Sands]

Hi Dan,

> Fix a few places in DAGCombiner that were creating all-ones-bits
> and high-bits values in ways that weren't correct for integer
> types wider than 64 bits. This fixes a miscompile in
> PPMacroExpansion.cpp in clang on x86-64.

this is not a problem with your patch, but I notice that this part
of the DAG combiner seems to make a lot of unsafe use of get?ExtValue.
Any chance of adding this to your TODO list? :)

Ciao,

Duncan.