[llvm-commits] [llvm] r79321 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp

Chris Lattner sabre at nondot.org
Mon Aug 17 23:03:07 PDT 2009


Author: lattner
Date: Tue Aug 18 01:03:07 2009
New Revision: 79321

URL: http://llvm.org/viewvc/llvm-project?rev=79321&view=rev
Log:
remove some pointless null switchtosections.  The IntelAsmPrinter doesn't really work anyway.

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp?rev=79321&r1=79320&r2=79321&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp Tue Aug 18 01:03:07 2009
@@ -493,14 +493,14 @@
   case GlobalValue::LinkOnceODRLinkage:
   case GlobalValue::WeakAnyLinkage:
   case GlobalValue::WeakODRLinkage:
-    SwitchToSection(0);
+    // FIXME: make a MCSection.
     O << name << "?\tSEGEMNT PARA common 'COMMON'\n";
     bCustomSegment = true;
     // FIXME: the default alignment is 16 bytes, but 1, 2, 4, and 256
     // are also available.
     break;
   case GlobalValue::AppendingLinkage:
-    SwitchToSection(0);
+    // FIXME: make a MCSection.
     O << name << "?\tSEGMENT PARA public 'DATA'\n";
     bCustomSegment = true;
     // FIXME: the default alignment is 16 bytes, but 1, 2, 4, and 256
@@ -538,7 +538,6 @@
 bool X86IntelAsmPrinter::doFinalization(Module &M) {
   // Output linker support code for dllexported globals
   if (!DLLExportedGVs.empty() || !DLLExportedFns.empty()) {
-    SwitchToSection(0);
     O << "; WARNING: The following code is valid only with MASM v8.x"
       << "and (possible) higher\n"
       << "; This version of MASM is usually shipped with Microsoft "
@@ -564,7 +563,6 @@
 
   // Bypass X86SharedAsmPrinter::doFinalization().
   bool Result = AsmPrinter::doFinalization(M);
-  SwitchToSection(0);
   O << "\tend\n";
   return Result;
 }





More information about the llvm-commits mailing list