[llvm-commits] calling convention support for ARM AAPCS VFP "homogenous aggregates"

[Sandeep Patel]

On Sun, Aug 16, 2009 at 2:08 AM, Bob Wilson<bob.wilson at apple.com> wrote:
>
> On Aug 15, 2009, at 8:47 AM, Sandeep Patel wrote:
>
>> On Sat, Aug 15, 2009 at 3:20 PM, Bob Wilson<bob.wilson at apple.com> wrote:
>>>
>>> Yes, build_gcc uses -Werror.   Your patch fixes the warning, but I wasn't
>>> expecting to see a cast there -- I thought one of your patches changed it
>>> to
>>> use CallingConv::ID everywhere instead of unsigned.  Did you miss
>>> something
>>> or is there a reason to keep it an unsigned in some places?
>>
>> The patch covered everywhere in llvm-gcc, not LLVM proper. There are a
>> couple of wrinkles in doing the same to LLVM: the C API takes an
>> unsigned in LLVMSetFunctionCallConv() and LLParser needs to
>> ParseUInt32() in ParseOptionalCallingConv(). An hour before getting on
>> a plane doesn't seem like the time to submit a patch that changes the
>> API, so I think we can revisit the LLVM part of this cleanup later.
>
> OK, that makes sense to me.

Attached is the retyping from unsigned to CallingConv::ID in LLVM
proper. It's largely mechanical. I left the C API signatures the same,
but changed the C++ ones.

deep
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deep-llvm-callconv-retype.diff
Type: application/octet-stream
Size: 71744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090816/ad96f246/attachment.obj>