[llvm-commits] [llvm] r78937 - in /llvm/trunk: include/llvm/MC/MCSectionELF.h lib/MC/MCSectionELF.cpp

[Chris Lattner]

On Aug 13, 2009, at 7:18 PM, Bruno Cardoso Lopes wrote:

>>> Author: bruno
>>> Date: Thu Aug 13 16:08:56 2009
>>> New Revision: 78937
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=78937&view=rev
>>> Log:
>>> Add a method to return if the ELF section contains only common  
>>> symbols!
>>
>> Nice, but aren't weak symbols put in gnu.linkonce also?
>
> Yes, if the section contains only common symbols, it will have its  
> section
> header index pointing to SHN_COMMON (which is a reserved section  
> header
> index), and it takes precedence over Weak, marking the symbols as  
> STB_GLOBAL
> instead of STB_WEAK.

Ok, please pick a better/more descriptive name than 'is common' then :)

-Chris