[llvm-commits] [llvm] r78983 - in /llvm/trunk: include/llvm/MC/MCSymbol.h lib/MC/MCSymbol.cpp lib/MC/MCValue.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Thu Aug 13 22:41:23 2009
New Revision: 78983

URL: http://llvm.org/viewvc/llvm-project?rev=78983&view=rev
Log:
Add MCSymbol::{print, dump}

Added:
    llvm/trunk/lib/MC/MCSymbol.cpp
Modified:
    llvm/trunk/include/llvm/MC/MCSymbol.h
    llvm/trunk/lib/MC/MCValue.cpp

Modified: llvm/trunk/include/llvm/MC/MCSymbol.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSymbol.h?rev=78983&r1=78982&r2=78983&view=diff

==============================================================================
--- llvm/trunk/include/llvm/MC/MCSymbol.h (original)
+++ llvm/trunk/include/llvm/MC/MCSymbol.h Thu Aug 13 22:41:23 2009
@@ -20,6 +20,7 @@
 namespace llvm {
   class MCSection;
   class MCContext;
+  class raw_ostream;
 
   /// MCSymbol - Instances of this class represent a symbol name in the MC file,
   /// and MCSymbols are created and unique'd by the MCContext class.
@@ -61,6 +62,12 @@
     void setExternal(bool Value) { IsExternal = Value; }
 
     const std::string &getName() const { return Name; }
+
+    /// print - Print the value to the stream \arg OS.
+    void print(raw_ostream &OS) const;
+
+    /// dump - Print the value to stderr.
+    void dump() const;
   };
 
 } // end namespace llvm

Added: llvm/trunk/lib/MC/MCSymbol.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSymbol.cpp?rev=78983&view=auto

==============================================================================
--- llvm/trunk/lib/MC/MCSymbol.cpp (added)
+++ llvm/trunk/lib/MC/MCSymbol.cpp Thu Aug 13 22:41:23 2009
@@ -0,0 +1,49 @@
+//===- lib/MC/MCSymbol.cpp - MCSymbol implementation ----------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/MC/MCSymbol.h"
+#include "llvm/Support/raw_ostream.h"
+
+using namespace llvm;
+
+/// NeedsQuoting - Return true if the string \arg Str needs quoting, i.e., it
+/// does not match [a-zA-Z_.][a-zA-Z0-9_.]*.
+//
+// FIXME: This could be more permissive, do we care?
+static inline bool NeedsQuoting(const StringRef &Str) {
+  if (Str.empty())
+    return true;
+
+  // Check that first character is in [a-zA-Z_.].
+  if (!((Str[0] >= 'a' && Str[0] <= 'z') ||
+        (Str[0] >= 'A' && Str[0] <= 'Z') ||
+        (Str[0] == '_' || Str[0] == '.')))
+    return true;
+
+  // Check subsequent characters are in [a-zA-Z0-9_.].
+  for (unsigned i = 1, e = Str.size(); i != e; ++i)
+    if (!((Str[i] >= 'a' && Str[i] <= 'z') ||
+          (Str[i] >= 'A' && Str[i] <= 'Z') ||
+          (Str[i] >= '0' && Str[i] <= '9') ||
+          (Str[i] == '_' || Str[i] == '.')))
+      return true;
+
+  return false;
+}
+
+void MCSymbol::print(raw_ostream &OS) const {
+  if (NeedsQuoting(getName()))
+    OS << '"' << getName() << '"';
+  else
+    OS << getName();
+}
+
+void MCSymbol::dump() const {
+  print(errs());
+}

Modified: llvm/trunk/lib/MC/MCValue.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCValue.cpp?rev=78983&r1=78982&r2=78983&view=diff

==============================================================================
--- llvm/trunk/lib/MC/MCValue.cpp (original)
+++ llvm/trunk/lib/MC/MCValue.cpp Thu Aug 13 22:41:23 2009
@@ -18,9 +18,13 @@
     return;
   }
 
-  OS << getSymA();
-  if (getSymB())
-    OS << " - " << getSymB();
+  getSymA()->print(OS);
+
+  if (getSymB()) {
+    OS << " - "; 
+    getSymB()->print(OS);
+  }
+
   if (getConstant())
     OS << " + " << getConstant();
 }