[llvm-commits] [llvm] r78603 - in /llvm/trunk/lib/Target/PIC16: PIC16DebugInfo.cpp PIC16DebugInfo.h

Sanjiv.Gupta at microchip.com Sanjiv.Gupta at microchip.com
Thu Aug 13 10:33:26 PDT 2009


I'll try that and let you know.

- Sanjiv

> -----Original Message-----
> From: Devang Patel [mailto:dpatel at me.com]
> Sent: Thursday, August 13, 2009 10:51 PM
> To: Sanjiv Kumar Gupta - I00171
> Cc: Commit Messages and Patches for LLVM
> Subject: Re: [llvm-commits] [llvm] r78603 - in
> /llvm/trunk/lib/Target/PIC16: PIC16DebugInfo.cpp PIC16DebugInfo.h
> 
> Aha.. I see the bug in my patch.
> 
> 
> 
> 
> 
> 
> 			+  unsigned SuffixNo = 0;
> 
> 
> 			+  for (DebugInfoFinder::iterator I =
> DbgFinder.global_variable_begin(),
> 
> 
> 			+         E = DbgFinder.global_variable_end(); I
!= E;
> ++I) {
> 
> 
> 			+    DICompositeType CTy(*I);
> 
> 
> 			+    if (CTy.isNull())
> 
> 
> 			+      continue;
> 
> 
> Here it should use
> 
>   for(debugInfoFinder::iterator I = DbgFinder.type_begin(),
>        E = DbgFinder.type_end(); I != E; ++I) {
>      DICompositeType CTY(*I);
>      if (CTy.isNull())
>        continue;
> 
> 
> Can you try this ?
> Thanks,
> -
> Devang




More information about the llvm-commits mailing list