[llvm-commits] [llvm] r78843 - /llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp

[Benjamin Kramer]

Hi David

one comment below

On 12.08.09 23:47, David Goodwin wrote:
> Author: david_goodwin
> Date: Wed Aug 12 16:47:46 2009
> New Revision: 78843
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=78843&view=rev
> Log:
> Fix counting of Post-RA scheduling stalls. Improve debug output.
> 
> Modified:
>     llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp?rev=78843&r1=78842&r2=78843&view=diff
> 
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp (original)
> +++ llvm/trunk/lib/CodeGen/PostRASchedulerList.cpp Wed Aug 12 16:47:46 2009
> @@ -823,6 +823,10 @@
>      }
>    }
>  
> +  // In any cycle where we can't schedule any instructions, we must
> +  // stall or emit a noop, depending on the target.
> +  bool CycleInstCnt = 0;

Are you sure this variable is boolean?

…
> +      CycleInstCnt++;
…
> +      if (CycleInstCnt > 0) {

Please remove "> 0" here if it's boolean. It's causing a warning on MSVC.
…
> +      CycleInstCnt = 0;
…