[llvm-commits] [llvm] r76936 - in /llvm/trunk/lib/Target/Mips: MipsISelLowering.cpp MipsISelLowering.h MipsSubtarget.cpp MipsSubtarget.h

[Chris Lattner]

On Jul 24, 2009, at 12:40 PM, Bruno Cardoso Lopes wrote:

> On Fri, Jul 24, 2009 at 1:32 PM, Chris Lattner<clattner at apple.com>  
> wrote:
>>
>> On Jul 24, 2009, at 12:36 AM, Bruno Cardoso Lopes wrote:
>>
>>> Hi Chris,
>>>
>>> The small section thing on Mips is used to guarantee that the  
>>> section
>>> could be addressed will "gp_rel" relocation, which requires only one
>>> instruction
>>> and the same is not true for normal data relocations on Mips. How do
>>> you suggest
>>> that we keep this behaviour? The "-G" switch is used on psp homebrew
>>> stuff and I would like to have this functionality if possible.
>>
>> Ah, this is unfortunate.  I didn't know that anyone was actually  
>> using
>> this, based on the previous exchange.  I will pull this back in after
>> I get some other stuff rearranged.
>>
>> Can you check in an xfailed testcase that shows the instruction
>> generation of this gprel access?  There was nothing in the testsuite
>> that showed it.
>
> The smallsection test removed in the other commit already check for  
> the
> "gp_rel", but I'll provide a specific test for it when you revert  
> the changes.

Ok, I restored this patch, but we still don't have a testcase for the - 
mips-ssection-threshold option.

-Chris