[llvm-commits] [llvm] r78891 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/vec_extract_elt2.ll

[Mon P Wang]

Author: wangmp
Date: Thu Aug 13 00:12:13 2009
New Revision: 78891

URL: http://llvm.org/viewvc/llvm-project?rev=78891&view=rev
Log:
When InstCombine simplifies a load -> extract element to gep -> load, place
the new load by the old load instead of by the extract element because
a store could have occurred between the load and extract element.

Added:
    llvm/trunk/test/Transforms/InstCombine/vec_extract_elt2.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=78891&r1=78890&r2=78891&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Thu Aug 13 00:12:13 2009
@@ -12465,12 +12465,14 @@
         unsigned AS = 
           cast<PointerType>(I->getOperand(0)->getType())->getAddressSpace();
         Value *Ptr = InsertBitCastBefore(I->getOperand(0),
-                                  PointerType::get(EI.getType(), AS),EI);
+                                  PointerType::get(EI.getType(), AS),*I);
         GetElementPtrInst *GEP =
           GetElementPtrInst::Create(Ptr, EI.getOperand(1), I->getName()+".gep");
         cast<GEPOperator>(GEP)->setIsInBounds(true);
-        InsertNewInstBefore(GEP, EI);
-        return new LoadInst(GEP);
+        InsertNewInstBefore(GEP, *I);
+        LoadInst* Load = new LoadInst(GEP, "tmp");
+        InsertNewInstBefore(Load, *I);
+        return ReplaceInstUsesWith(EI, Load);
       }
     }
     if (InsertElementInst *IE = dyn_cast<InsertElementInst>(I)) {

Added: llvm/trunk/test/Transforms/InstCombine/vec_extract_elt2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/vec_extract_elt2.ll?rev=78891&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/vec_extract_elt2.ll (added)
+++ llvm/trunk/test/Transforms/InstCombine/vec_extract_elt2.ll Thu Aug 13 00:12:13 2009
@@ -0,0 +1,23 @@
+; RUN: llvm-as < %s | opt -instcombine | llvm-dis | FileCheck %s
+
+; The load replacing the extract element must occur before the call
+; that may modify local array a.
+
+declare void @mod_a_func(<4 x float>* %a);
+
+; CHECK: load float* %arraydecay1, align 16
+; CHECK: call void @mod_a_func
+
+define void @cl_jpegenc_k2(<4 x float> addrspace(1)* %src, float addrspace(1)* %dst) {
+  %a = alloca [2 x <4 x float>], align 16
+  %arraydecay = getelementptr [2 x <4 x float>]* %a, i32 0, i32 0
+  %arrayidx31 = getelementptr <4 x float> addrspace(1)* %src, i32 0
+  %tmp32 = load <4 x float> addrspace(1)* %arrayidx31
+  store <4 x float> %tmp32, <4 x float>* %arraydecay, align 16
+  %tmp86 = load <4 x float>* %arraydecay, align 16
+  call void @mod_a_func(<4 x float>* %arraydecay)
+  %arrayidx132 = getelementptr float addrspace(1)* %dst, i32 0
+  %tmp236 = extractelement <4 x float> %tmp86, i32 0
+  store float %tmp236, float addrspace(1)* %arrayidx132
+  ret void
+}
\ No newline at end of file