[llvm-commits] [llvm] r78872 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp

[Chris Lattner]

On Aug 12, 2009, at 5:28 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Wed Aug 12 19:28:52 2009
> New Revision: 78872
>
> URL: http://llvm.org/viewvc/llvm-project?rev=78872&view=rev
> Log:
> Symbols with LinkerPrivateLinkage are weak.
> This allows WebKit to build again.

What specifically does this change?  Can you add a regtest?  Do ppc/ 
arm need a similar fix?

-Chris

>
>
> Modified:
>    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=78872&r1=78871&r2=78872&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp  
> (original)
> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp Wed  
> Aug 12 19:28:52 2009
> @@ -174,12 +174,12 @@
>   default: llvm_unreachable("Unknown linkage type!");
>   case Function::InternalLinkage:  // Symbols default to internal.
>   case Function::PrivateLinkage:
> -  case Function::LinkerPrivateLinkage:
>     break;
>   case Function::DLLExportLinkage:
>   case Function::ExternalLinkage:
>     O << "\t.globl\t" << CurrentFnName << '\n';
>     break;
> +  case Function::LinkerPrivateLinkage:
>   case Function::LinkOnceAnyLinkage:
>   case Function::LinkOnceODRLinkage:
>   case Function::WeakAnyLinkage:
> @@ -853,6 +853,7 @@
>   case GlobalValue::LinkOnceODRLinkage:
>   case GlobalValue::WeakAnyLinkage:
>   case GlobalValue::WeakODRLinkage:
> +  case GlobalValue::LinkerPrivateLinkage:
>     if (Subtarget->isTargetDarwin()) {
>       O << "\t.globl " << name << '\n'
>         << TAI->getWeakDefDirective() << name << '\n';
> @@ -872,7 +873,6 @@
>     O << "\t.globl " << name << '\n';
>     // FALL THROUGH
>   case GlobalValue::PrivateLinkage:
> -  case GlobalValue::LinkerPrivateLinkage:
>   case GlobalValue::InternalLinkage:
>      break;
>   default:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits