[llvm-commits] [llvm] r78594 - in /llvm/trunk: lib/Target/ARM/ARMISelDAGToDAG.cpp test/CodeGen/Thumb2/2009-08-10-ISelBug.ll

[Evan Cheng]

On Aug 10, 2009, at 2:00 PM, Eli Friedman wrote:

> On Mon, Aug 10, 2009 at 1:25 PM, Evan Cheng<evan.cheng at apple.com>  
> wrote:
>> Author: evancheng
>> Date: Mon Aug 10 15:25:59 2009
>> New Revision: 78594
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=78594&view=rev
>> Log:
>> Handle the constantfp created during post-legalization dag combiner  
>> phase.
>
> AFAIK, dagcombine isn't  supposed to create illegal constantfp nodes
> post-legalize... perhaps it would be better to fix the issue there?

Yes and no. These transformations are somewhat essential so perhaps  
the *right* solution is to emit loads from constantpool instead of  
constantfp nodes. On the other hand, ARM isel is able to handle  
constantfp nodes. So it seems perfectly ok to consider them legal.

Evan

>
> -Eli
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits