[llvm-commits] [llvm] r78514 - in /llvm/trunk/lib/Target/ARM: ARMInstrInfo.td ARMInstrNEON.td ARMInstrThumb.td ARMInstrThumb2.td AsmPrinter/ARMAsmPrinter.cpp

[Bob Wilson]

On Aug 9, 2009, at 3:37 PM, Daniel Dunbar wrote:

> On Sat, Aug 8, 2009 at 9:44 PM, Bob Wilson<bob.wilson at apple.com>  
> wrote:
>> I have a vague idea of what Daniel's thinking, but I'm not sure I get
>> it.  It is kind of weird to have "lane_cst" and "printLaneOperand"  
>> for
>> things that have nothing to do with Neon lanes.  Maybe it would be
>> better to keep the "no_hash" name instead of "lane"?  Somehow I
>> suspect that would defeat the purpose.
>
> The name doesn't matter, I would just prefer not to use modifiers for
> things we can express in the .td following existing mechanisms. The
> modifiers are too free form (strstr?) and there is no place to attach
> extra metadata, for example to explain how they should be parsed.
>
> Does that make sense?

So you're not trying to distinguish lane numbers from other immediate  
operands that are printed without hash marks?  In that case I  
definitely prefer a "no_hash" name, or something like that.  It sounds  
like Anton doesn't care too much about the name, so unless someone  
objects, I'll change it sometime.