[llvm-commits] [PATCH] Use AssertingVH for the GlobalValue maps

[jyasskin at gmail.com]

Reviewers: llvm-commits_cs.uiuc.edu,

Description:
To catch bugs like the one fixed in
http://llvm.org/viewvc/llvm-project?view=rev&revision=78127, I'm
changing the ExecutionEngine's global mappings to hold AssertingVH<const
GlobalValue>. That way, if unregistering a mapping fails to actually
unregister it, we'll get an assert. Running the jit nightly tests
doesn't uncover any actual instances of the problem.

This also uncovered the fact that AssertingVH<const X> didn't work, so I
fixed that too.

Please review this at http://codereview.appspot.com/104054

Affected files:
   M     include/llvm/ExecutionEngine/ExecutionEngine.h
   M     include/llvm/Support/ValueHandle.h
   M     lib/ExecutionEngine/ExecutionEngine.cpp
   M     unittests/Support/ValueHandleTest.cpp