[llvm-commits] [llvm] r78255 - in /llvm/trunk/lib/Target/X86: X86ISelDAGToDAG.cpp X86ISelLowering.cpp X86ISelLowering.h

[Chris Lattner]

On Aug 5, 2009, at 7:09 PM, Daniel Dunbar wrote:

> On Wed, Aug 5, 2009 at 4:01 PM, Anton Korobeynikov<asl at math.spbu.ru>  
> wrote:
>> Author: asl
>> Date: Wed Aug  5 18:01:26 2009
>> New Revision: 78255
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=78255&view=rev
>> Log:
>> Better handle kernel code model. Also, generalize the things and  
>> fix one
>> subtle bug with small code model.
>
> Seems like the "subtle bug" should get a test case?

Yes, Anton, we really need tests for this sort of thing.  Please add a  
test that shows these, otherwise I will break them in the future.   
Please duplicate the comment from the .h file and expand on it.

>> +bool X86::isOffsetSuitableForCodeModel(int64_t Offset,  
>> CodeModel::Model M,
>> +                                       bool  
>> hasSymbolicDisplacement) {

This also needs a big doxygen comment explaining what this does and  
what the arguments are.  The comments in the body of the function are  
great.

-Chris