[llvm-commits] [llvm] r78142 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/Target/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/Blackfin/ lib/Target/CellSPU/ lib/Target/MSP430/ lib/Target/Mips/ lib/Target/PIC16/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/SystemZ/ lib/Target/X86/ lib/Target/XCore/ test/CodeGen/X86/

[Chris Lattner]

On Aug 5, 2009, at 7:20 PM, Sanjiv Gupta wrote:

> Chris Lattner wrote:
>>
>> On Aug 5, 2009, at 8:56 AM, Sanjiv Gupta wrote:
>>
>>> Hi Dan,
>>> This causes an assert in quite a few of our tests for codegen.
>>> I just added one as test/CodeGen/PIC16/sext.ll
>>
>> Sanjiv, if the test is known broken, please xfail it.  Not doing so  
>> breaks all the buildbots.
>>
>> -Chris
>>
> Chris,
> I just marked it XFAIL, while Dan gets a chance to look at it.

Actually, I went ahead and marked it xfail to fix the testers.  Then  
dan fixed the problem (in the pic16 backend) and unxfailed the test.   
You xfailed a passing test.

I corrected the test.  Are you running make check?

-Chris