[llvm-commits] [llvm] r78127 - in /llvm/trunk: lib/ExecutionEngine/ExecutionEngine.cpp unittests/ExecutionEngine/ExecutionEngineTest.cpp unittests/ExecutionEngine/Makefile

[Chris Lattner]

On Aug 5, 2009, at 8:34 AM, Jeffrey Yasskin wrote:

>>> T2 *obj2 = new T2;  // Happens to land at the same address.
>>> engine.addGlobalMapping(UnrelatedGV, obj2);
>>>
>>> and I don't see how AssertingVH would make any of that illegal or
>>> work better.
>>
>> If "updateglobalmapping" to null deletes the entry out of the map,
>> then assertingvh should work fine.
>
> Oh, I see what you're going for. Yep, I'll switch those GlobalValue*s
> to AssertingVH's (since going to CallbackVHs will take longer) and run
> the nightly tests to see what else needs fixing.

Nice, thanks!

-Chris