[llvm-commits] [llvm] r78097 - in /llvm/trunk: include/llvm/LLVMContext.h lib/VMCore/Constants.cpp lib/VMCore/LLVMContextImpl.cpp lib/VMCore/LLVMContextImpl.h

[Chris Lattner]

On Aug 4, 2009, at 8:43 PM, Owen Anderson wrote:

> On Aug 4, 2009, at 7:32 PM, Chris Lattner wrote:
>> Also, LLVMContext should be uniformly declared as a class:
>> http://llvm.org/docs/CodingStandards.html#ci_class_struct
>
> Actually, it is intended to be an all-members-are-public type, so  
> struct is appropriate.  The only use of private is to prevent the  
> compiler from generating default and copy constructors, not to  
> define actual members.

Fine, its implementation is private to vmcore, right?  Since it has to  
be forward declared in various headers, why not use class?

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090804/052953df/attachment.html>