[llvm-commits] [llvm] r78097 - in /llvm/trunk: include/llvm/LLVMContext.h lib/VMCore/Constants.cpp lib/VMCore/LLVMContextImpl.cpp lib/VMCore/LLVMContextImpl.h

[Chris Lattner]

On Aug 4, 2009, at 5:52 PM, Dan Gohman wrote:

>
> On Aug 4, 2009, at 1:25 PM, Owen Anderson wrote:
>> -class LLVMContext {
>> +struct LLVMContext {
>>  LLVMContextImpl* pImpl;
>
> Hi Owen,
>
> With the pImpl member being public, would it make sense to make
> it const? It looks like it's never modified after its initialization
> in the LLVMContext constructor. Alternatively, perhaps this could
> be accessed with an accessor function.

Also, LLVMContext should be uniformly declared as a class:
http://llvm.org/docs/CodingStandards.html#ci_class_struct

-Chris