[llvm-commits] [PATCH] Dump with LI Indices

[David Greene]

On Tuesday 04 August 2009 12:44, Chris Lattner wrote:
> On Aug 4, 2009, at 6:46 AM, David Greene wrote:
> > On Tuesday 04 August 2009 01:08, Evan Cheng wrote:
> >> I am really not crazy about it especially since it has such a generic
> >> name Dump.h. But it's not a big deal.
> >
> > I'm open to a better naming.  I'm not particulrly fond of Dump.h
> > either.
>
> I still don't understand why you need a general "prefix printer"
> mechanism, instead of just doing a simple helper function in the
> liveintervals code.

How would you do a helper function?  Remember, dumps happen lots of places 
before and after LiveIntervals has run.  Are you suggesting that the
MachineFunction and MachineBasicBlock dump routines call directly into 
LiveIntervals?  If so, then we'll need a flag to tell the dump routines to 
*not* do that.  That seems less clean to me.

                              -Dave