[llvm-commits] [llvm] r77740 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/2009-04-17-tls-fast.ll test/CodeGen/X86/tls1-pic.ll test/CodeGen/X86/tls2-pic.ll test/CodeGen/X86/tls3-pic.ll test/CodeGen/X86/tls4-pic.ll utils/TableGen/AsmWriterEmitter.cpp

[Chris Lattner]

On Aug 3, 2009, at 4:36 PM, David Greene wrote:

> On Monday 03 August 2009 17:11, David Greene wrote:
>
>>
>> AsmWriterEmitter no longer emits tabs into the AsmStrs because of  
>> this.  So
>> you're right, all this ugly complexity can go away.  Hmm...except  
>> this
>> probably doesn't work for "pd" suffixed mnemonics as I pointed out  
>> earlier.
>> So there's a bug here.  I'll figure that out.
>
> I've got a fix for this and a cleanup to boot.  Testing now, will  
> apply
> probably tomorrow.

Thank you Dave,

I really prefer that this change (the comment formatting stuff for  
operands) get settled before many more patches go in.  I can only keep  
track of so many outstanding issues at a time.  Once it is "right" I  
can stop fretting about it :)

Thanks again for working on this, it seems like the solution is  
converging to a really really nice place.

-Chris