[llvm-commits] [llvm] r77706 - in /llvm/trunk: include/llvm/Support/Annotation.h lib/Support/Annotation.cpp

[Chris Lattner]

On Aug 3, 2009, at 2:01 AM, Nicolas Geoffray wrote:

> Hi Dan,
>
> Dan Gohman wrote:
>> Author: djg
>> Date: Fri Jul 31 13:36:25 2009
>> New Revision: 77706
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=77706&view=rev
>> Log:
>> Remove Annotation.h, which is no longer used in the LLVM tree.
>>
>
> I know this has been long waiting for LLVM and I'm happy you got rid  
> of
> it. Unfortunately, I was using Annotations to add VM-info per function
> in VMKit (e.g. a way to get the Java method out of a llvm::Function),
> and I'm reluctant into using a table to store that information now  
> that
> the Annotation class is removed.
>

Hi Nicolas,

Why can't you just use a std::map or DenseMap on the side?  Trying to  
actually *attach* data to LLVM IR objects is a really fragile thing to  
try to do.  If the entire rest of the compiler can get away without  
it, I don't see why vmkit needs to do it.

-Chris